fengjiajie commented on code in PR #23593:
URL: https://github.com/apache/flink/pull/23593#discussion_r1372988296
##########
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/hybrid/HybridSourceSplitEnumeratorTest.java:
##########
@@ -252,6 +252,41 @@ public void testInterceptNoMoreSplitEvent() {
assertThat(context.hasNoMoreSplits(0)).isTrue();
}
+ @Test
+ public void testMultiSubtaskSwitchEnumerator() {
+ context = new MockSplitEnumeratorContext<>(2);
+ source =
+ HybridSource.builder(MOCK_SOURCE)
+ .addSource(MOCK_SOURCE)
+ .addSource(MOCK_SOURCE)
+ .build();
+
+ enumerator = (HybridSourceSplitEnumerator)
source.createEnumerator(context);
+ enumerator.start();
+
+ registerReader(context, enumerator, SUBTASK0);
+ registerReader(context, enumerator, SUBTASK1);
+ enumerator.handleSourceEvent(SUBTASK0, new
SourceReaderFinishedEvent(-1));
+ enumerator.handleSourceEvent(SUBTASK1, new
SourceReaderFinishedEvent(-1));
+
+ assertThat(getCurrentSourceIndex(enumerator)).isEqualTo(0);
+ enumerator.handleSourceEvent(SUBTASK0, new
SourceReaderFinishedEvent(0));
+ enumerator.handleSourceEvent(SUBTASK1, new
SourceReaderFinishedEvent(0));
+ assertThat(getCurrentSourceIndex(enumerator))
+ .as("all reader finished source-0")
+ .isEqualTo(1);
+
+ enumerator.handleSourceEvent(SUBTASK0, new
SourceReaderFinishedEvent(1));
+ assertThat(getCurrentSourceIndex(enumerator))
+ .as(
+ "only reader-0 has finished reading, reader-1 is not
yet done, so do not switch to the next source")
+ .isEqualTo(1);
Review Comment:
Before this PR modification, the assert will fail here, which means
switching to the next source only after one reader completes reading
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
