afedulov commented on PR #23553: URL: https://github.com/apache/flink/pull/23553#issuecomment-1781183357
@zentol I made two major changes as per our discussions above: - https://github.com/apache/flink/commit/2712c1813ca6420905e06b9e417de0eb61d586d9 - direct type passing without the requirement to use returns() (please see my [comment](https://github.com/apache/flink/pull/23553#discussion_r1372403767) above) - https://github.com/apache/flink/pull/23553/commits/78cb92bc86e9dded9bf2458de119d549be7ad281 - allow parallel execution of fromElements Sources The second one might need some additional test fixes, but I cannot get to them at the moment because of the `japicmp` failures: ``` Failed to execute goal io.github.zentol.japicmp:japicmp-maven-plugin:0.17.1.1_m325:cmp (default) on project flink-streaming-java: There is at least one incompatibility: org.apache.flink.streaming.api.environment.StreamExecutionEnvironment.fromElements(org.apache.flink.api.common.typeinfo.TypeInformation,java.lang.Object[]):CLASS_GENERIC_TEMPLATE_CHANGED -> [Help 1] ``` This is the diff: ``` +++* NEW METHOD: PUBLIC(+) FINAL(+) org.apache.flink.streaming.api.datastream.DataStreamSource<OUT> fromElements(org.apache.flink.api.common.typeinfo.TypeInformation<OUT>, java.lang.Object[]) +++ NEW ANNOTATION: java.lang.SafeVarargs GENERIC TEMPLATES: +++ OUT:java.lang.Object ``` What is the issue with adding the new method? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
