dawidwys commented on code in PR #23601:
URL: https://github.com/apache/flink/pull/23601#discussion_r1373338635
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesRuntimeFunctions.java:
##########
@@ -522,11 +540,13 @@ public void invoke(RowData value, Context context) throws
Exception {
synchronized (LOCK) {
localRawResult.add(row);
if (kind == RowKind.INSERT || kind == RowKind.UPDATE_AFTER) {
- row.setKind(RowKind.INSERT);
- localRetractResult.add(row);
+ final Row retractRow = Row.copy(row);
Review Comment:
It's late :( I thought there is `else if` not `else` in the second branch 🤦
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesRuntimeFunctions.java:
##########
@@ -522,11 +540,13 @@ public void invoke(RowData value, Context context) throws
Exception {
synchronized (LOCK) {
localRawResult.add(row);
if (kind == RowKind.INSERT || kind == RowKind.UPDATE_AFTER) {
- row.setKind(RowKind.INSERT);
- localRetractResult.add(row);
+ final Row retractRow = Row.copy(row);
Review Comment:
It's late :( I thought there is `else if` not `else` in the second branch 🤦
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
