[ https://issues.apache.org/jira/browse/FLINK-5012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15647929#comment-15647929 ]
ASF GitHub Bot commented on FLINK-5012: --------------------------------------- GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/2772 [FLINK-5012] Expose Timestamp in Timely FlatMap Functions This also adds a Context parameter that holds the timestamp, time domain and TimerService to declutter the parameter list of the functions. R: @StefanRRichter and @kl0u for review, please CC: @jgrier You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink timely-timestamp Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/2772.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2772 ---- commit 3b37adbd87744ff23d075f03d0259b87536265a9 Author: Aljoscha Krettek <aljoscha.kret...@gmail.com> Date: 2016-11-08T15:52:21Z [FLINK-5012] Expose Timestamp in Timely FlatMap Functions This also adds a Context parameter that holds the timestamp, time domain and TimerService to declutter the parameter list of the functions. ---- > Provide Timestamp in TimelyFlatMapFunction > ------------------------------------------ > > Key: FLINK-5012 > URL: https://issues.apache.org/jira/browse/FLINK-5012 > Project: Flink > Issue Type: Improvement > Components: Streaming > Reporter: Aljoscha Krettek > > Right now, {{TimelyFlatMapFunction}} does not give the timestamp of the > element in {{flatMap()}}. > The signature is currently this: > {code} > void flatMap(I value, TimerService timerService, Collector<O> out) throws > Exception; > {code} > if we add the timestamp it would become this: > {code} > void flatMap(I value, Long timestamp, TimerService timerService, Collector<O> > out) throws Exception; > {code} > The reason why it's a {{Long}} and not a {{long}} is that an element might > not have a timestamp, in that case we should hand in {{null}} here. > This is becoming quite look so we could add a {{Context}} parameter that > provides access to the timestamp and timer service. -- This message was sent by Atlassian JIRA (v6.3.4#6332)