Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2754#discussion_r87028376
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/BarrierBuffer.java
---
@@ -254,8 +357,20 @@ public void cleanup() throws IOException {
for (BufferSpiller.SpilledBufferOrEventSequence seq :
queuedBuffered) {
seq.cleanup();
}
+ queuedBuffered.clear();
}
-
+
+ private void beginNewAlignment(long checkpointId, int channelIndex)
throws IOException {
+ currentCheckpointId = checkpointId;
+ onBarrier(channelIndex);
+
+ startOfAlignmentTimestamp = System.nanoTime();
+
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Starting stream alignment for checkpoint " +
checkpointId);
--- End diff --
When guarded this here is actually the more efficient pattern. So, i'd lean
towards ignoring/deactivating that warning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
