gyfora commented on PR #23490: URL: https://github.com/apache/flink/pull/23490#issuecomment-1788648931
> Thanks, @gyfora. I did another (partial) pass over the PR. I stopped after realizing that there is quite some room for improving the `PojoSerializer` code (this is not due to your changes but the class' current state in general. It comes with duplicated code as far as I can see. The change of this PR just would make it worse). > > I documented my finding in the `deserialize` methods. The same applies to the `copy` methods. I'm curious what you think. > > Additionally, there are a few review comments of mine that you didn't address but also didn't resolve. Could you either mark them as resolved w/o fixing it (which I'm also ok with if you think it's too much) or address the comment (e.g. [this one](https://github.com/apache/flink/pull/23490/files#r1365477495))? I just want to make sure that comments are not accidentally missed. Thanks @XComp , I will try to accommodate some of your suggestions. The pojoserializer has a lot of duplication that’s true but I intentionally did not want to refactor unrelated code as this is quite performance (and otherwise) sensitive area :) I will see what we can do with confidence but I am not going to dive too deep in the refactoring -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
