XComp commented on code in PR #23490: URL: https://github.com/apache/flink/pull/23490#discussion_r1388577908
########## flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializer.java: ########## @@ -400,21 +444,23 @@ public T deserialize(DataInputView source) throws IOException { target = createInstance(); } - if ((flags & NO_SUBCLASS) != 0) { + if (isRecord) { + JavaRecordBuilderFactory<T>.JavaRecordBuilder builder = recordHelper.newBuilder(); Review Comment: Ok, now I see where I was wrong: I was too distracted by the redundant code that I didn't see that the `IllegalAccessException` is thrown by the `Field#set` method which is not present in the first code block. Sorry for bringing this up over and over again :facepalm: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org