gyfora commented on code in PR #706:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/706#discussion_r1390245416
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkServiceTest.java:
##########
@@ -673,9 +693,11 @@ public void nativeSavepointFormatTest() throws Exception {
.set(OPERATOR_SAVEPOINT_FORMAT_TYPE,
SavepointFormatType.NATIVE),
false);
assertTrue(stopWithSavepointFuture.isDone());
- assertEquals(jobID, stopWithSavepointFuture.get().f0);
- assertEquals(SavepointFormatType.NATIVE,
stopWithSavepointFuture.get().f1);
- assertEquals(savepointPath, stopWithSavepointFuture.get().f2);
+ if (!failAfterSavepointCompletes) {
+ assertEquals(jobID, stopWithSavepointFuture.get().f0);
+ assertEquals(SavepointFormatType.NATIVE,
stopWithSavepointFuture.get().f1);
+ assertEquals(savepointPath, stopWithSavepointFuture.get().f2);
+ }
Review Comment:
Am I missing something here, or why are we not validating the savepoint path
in both the failure and non failure case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
