1996fanrui commented on code in PR #708:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/708#discussion_r1390425243
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/FlinkOperator.java:
##########
@@ -190,7 +189,8 @@ void registerSessionJobController() {
var metricManager =
MetricManager.createFlinkSessionJobMetricManager(baseConfig,
metricGroup);
var statusRecorder = StatusRecorder.create(client, metricManager,
listeners);
- var reconciler = new SessionJobReconciler(eventRecorder,
statusRecorder);
+ var autoscaler = AutoscalerFactory.create(client, eventRecorder);
+ var reconciler = new SessionJobReconciler(eventRecorder,
statusRecorder, autoscaler);
Review Comment:
Session Job doesn't use the autoscaler before, and autoscaler will be used
after this PR, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
