mxm commented on code in PR #707:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/707#discussion_r1390917573
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java:
##########
@@ -115,10 +120,37 @@ public void cleanup(KEY jobKey) {
stateStore.removeInfoFromCache(jobKey);
}
- private void clearParallelismOverrides(Context ctx) throws Exception {
- var parallelismOverrides = stateStore.getParallelismOverrides(ctx);
- if (parallelismOverrides.isPresent()) {
+ private void clearStatesAfterAutoscalerDisabled(Context ctx) throws
Exception {
+ var needFlush = false;
+ var parallelismOverridesOpt = stateStore.getParallelismOverrides(ctx);
+ if (parallelismOverridesOpt.isPresent()) {
+ needFlush = true;
stateStore.removeParallelismOverrides(ctx);
+ }
+
+ var collectedMetricsOpt = stateStore.getCollectedMetrics(ctx);
+ if (collectedMetricsOpt.isPresent()) {
+ needFlush = true;
+ stateStore.removeCollectedMetrics(ctx);
Review Comment:
Let me follow up with a minor refactoring.
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java:
##########
@@ -115,10 +120,37 @@ public void cleanup(KEY jobKey) {
stateStore.removeInfoFromCache(jobKey);
}
- private void clearParallelismOverrides(Context ctx) throws Exception {
- var parallelismOverrides = stateStore.getParallelismOverrides(ctx);
- if (parallelismOverrides.isPresent()) {
+ private void clearStatesAfterAutoscalerDisabled(Context ctx) throws
Exception {
+ var needFlush = false;
+ var parallelismOverridesOpt = stateStore.getParallelismOverrides(ctx);
+ if (parallelismOverridesOpt.isPresent()) {
+ needFlush = true;
stateStore.removeParallelismOverrides(ctx);
+ }
+
+ var collectedMetricsOpt = stateStore.getCollectedMetrics(ctx);
+ if (collectedMetricsOpt.isPresent()) {
+ needFlush = true;
+ stateStore.removeCollectedMetrics(ctx);
Review Comment:
I think we will need a better abstraction to deal with the flushing. Very
easy to make mistakes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
