1996fanrui commented on PR #23658: URL: https://github.com/apache/flink/pull/23658#issuecomment-1809570312
> Sorry that I was on a trip last week and did not have a chance to take a look. The change looks good to me. Just one minor comment that it's better to annotate `TaskManagerLoadBalanceMode#loadFromConfiguration()` with `@Internal` to avoid indicating it as a public interface to users. Thanks @zhuzhurk for the review and good suggestion! cc @RocMarshal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org