RocMarshal commented on code in PR #78:
URL:
https://github.com/apache/flink-connector-jdbc/pull/78#discussion_r1397395729
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/JdbcInputFormat.java:
##########
@@ -99,7 +99,11 @@
* @see JdbcParameterValuesProvider
* @see PreparedStatement
* @see DriverManager
+ * @deprecated Please use {@link
org.apache.flink.connector.jdbc.source.JdbcSource} instead. The
+ * builder utils and parameters passing could be view {@link
Review Comment:
hi, @davidradl
Thank you very much for your comment.
Your concerns are reasonable.
Firstly, there are two questions:
1. There may be syntax issues with the expression. I just want to declare
here that this method has expired and requires the use of a new API for
development, with the new class declared here. I'll update the sentence.
2. A comprehensive document is indeed needed here to guide developers.
As https://issues.apache.org/jira/browse/FLINK-25420 mentioned in, there are
currently no plans to introduce relevant documents.
Of course, if you are willing to write usage documentation for this new API,
we would greatly appreciate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
