gaborgsomogyi commented on PR #712: URL: https://github.com/apache/flink-kubernetes-operator/pull/712#issuecomment-1823032588
Thanks for the efforts! I've gone through the code and the direction looks good in general. There are some points where we can simplify the code without changing the functionality: * It's not required to make the certs mount point configurable. A good how it can be done is `/opt/flink/artifacts`. This can spare quite some code lines. Of course keeping it optional still makes sense. * The template gives the possibility not to hardcode keys inside but just define the root yaml node. During YAML generation all the underneath subtree is just copied over. A good example is `livenessProbe`. This allows us to support any custom parameters without touching the template again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
