xuyangzhong commented on code in PR #23684:
URL: https://github.com/apache/flink/pull/23684#discussion_r1403213418
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/FunctionITCase.java:
##########
@@ -1698,6 +1717,32 @@ public void eval(@DataTypeHint("STRING") StringData s) {
}
}
+ /** This is an empty synchronous table function. */
+ private static class LookupTableLevel0Function<T> extends TableFunction<T>
{}
+
+ /**
+ * Synchronous table function that uses {@link RowData} type inference for
{@link
Review Comment:
It seems not to use the RowData type inference, right?
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/stream/sql/FunctionITCase.java:
##########
@@ -1698,6 +1717,32 @@ public void eval(@DataTypeHint("STRING") StringData s) {
}
}
+ /** This is an empty synchronous table function. */
+ private static class LookupTableLevel0Function<T> extends TableFunction<T>
{}
+
+ /**
+ * Synchronous table function that uses {@link RowData} type inference for
{@link
+ * LookupTableSource} and inherits {@link TableFunction} at multiple
levels.
+ */
+ public static class LookupTableWithoutHintLevel1Function
Review Comment:
Just curious, should we add a test like LookupTableWithHintLevel1Function
for considerations about the test orthogonality?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
