[ 
https://issues.apache.org/jira/browse/FLINK-33655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Nuyanzin updated FLINK-33655:
------------------------------------
    Description: 
ASM 9.5 (which has support for java 21[1]) came only with ArchUnit 1.1.0 [2]

With current ArchUnit(1.0.0) in case of jdk21 it fails

{noformat}
mvn clean install -DskipTests -Dfast -Pjava21-target
mvn verify -pl flink-architecture-tests/flink-architecture-tests-production/ 
-Darchunit.freeze.store.default.allowStoreUpdate=false
{noformat}
like
{noformat}
Nov 26 16:07:42 16:07:42.024 [ERROR] Tests run: 2, Failures: 0, Errors: 1, 
Skipped: 0, Time elapsed: 5.742 s <<< FAILURE! - in 
org.apache.flink.architecture.rules.ITCaseRules
Nov 26 16:07:42 16:07:42.025 [ERROR] ITCaseRules.ITCASE_USE_MINICLUSTER  Time 
elapsed: 0.005 s  <<< ERROR!
Nov 26 16:07:42 com.tngtech.archunit.library.freeze.StoreUpdateFailedException: 
Updating frozen violations is disabled (enable by configuration 
freeze.store.default.allowStoreUpdate=true)
Nov 26 16:07:42         at 
com.tngtech.archunit.library.freeze.ViolationStoreFactory$TextFileBasedViolationStore.save(ViolationStoreFactory.java:125)
Nov 26 16:07:42         at 
com.tngtech.archunit.library.freeze.FreezingArchRule$ViolationStoreLineBreakAdapter.save(FreezingArchRule.java:277)
Nov 26 16:07:42         at 
com.tngtech.archunit.library.freeze.FreezingArchRule.removeObsoleteViolationsFromStore(FreezingArchRule.java:154)
Nov 26 16:07:42         at 
com.tngtech.archunit.library.freeze.FreezingArchRule.removeObsoleteViolationsFromStoreAndReturnNewViolations(FreezingArchRule.java:146)
Nov 26 16:07:42         at 
com.tngtech.archunit.library.freeze.FreezingArchRule.evaluate(FreezingArchRule.java:127)
Nov 26 16:07:42         at 
com.tngtech.archunit.lang.ArchRule$Assertions.check(ArchRule.java:84)
Nov 26 16:07:42         at 
com.tngtech.archunit.library.freeze.FreezingArchRule.check(FreezingArchRule.java:97)

{noformat}

[1] https://asm.ow2.io/versions.html#9.5
[2] https://github.com/TNG/ArchUnit/pull/1098

  was:
ASM 9.5 (which has support for java 21[1]) came only with ArchUnit 1.1.0 [2]

With current ArchUnit(1.0.1) in case of jdk21 it fails

{noformat}
mvn clean install -DskipTests -Dfast -Pjava21-target
mvn verify -pl flink-architecture-tests/flink-architecture-tests-production/ 
-Darchunit.freeze.store.default.allowStoreUpdate=false
{noformat}
like
{noformat}
Nov 26 16:07:42 16:07:42.024 [ERROR] Tests run: 2, Failures: 0, Errors: 1, 
Skipped: 0, Time elapsed: 5.742 s <<< FAILURE! - in 
org.apache.flink.architecture.rules.ITCaseRules
Nov 26 16:07:42 16:07:42.025 [ERROR] ITCaseRules.ITCASE_USE_MINICLUSTER  Time 
elapsed: 0.005 s  <<< ERROR!
Nov 26 16:07:42 com.tngtech.archunit.library.freeze.StoreUpdateFailedException: 
Updating frozen violations is disabled (enable by configuration 
freeze.store.default.allowStoreUpdate=true)
Nov 26 16:07:42         at 
com.tngtech.archunit.library.freeze.ViolationStoreFactory$TextFileBasedViolationStore.save(ViolationStoreFactory.java:125)
Nov 26 16:07:42         at 
com.tngtech.archunit.library.freeze.FreezingArchRule$ViolationStoreLineBreakAdapter.save(FreezingArchRule.java:277)
Nov 26 16:07:42         at 
com.tngtech.archunit.library.freeze.FreezingArchRule.removeObsoleteViolationsFromStore(FreezingArchRule.java:154)
Nov 26 16:07:42         at 
com.tngtech.archunit.library.freeze.FreezingArchRule.removeObsoleteViolationsFromStoreAndReturnNewViolations(FreezingArchRule.java:146)
Nov 26 16:07:42         at 
com.tngtech.archunit.library.freeze.FreezingArchRule.evaluate(FreezingArchRule.java:127)
Nov 26 16:07:42         at 
com.tngtech.archunit.lang.ArchRule$Assertions.check(ArchRule.java:84)
Nov 26 16:07:42         at 
com.tngtech.archunit.library.freeze.FreezingArchRule.check(FreezingArchRule.java:97)

{noformat}

[1] https://asm.ow2.io/versions.html#9.5
[2] https://github.com/TNG/ArchUnit/pull/1098


> Upgrade Archunit to 1.1.0+
> --------------------------
>
>                 Key: FLINK-33655
>                 URL: https://issues.apache.org/jira/browse/FLINK-33655
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Tests
>    Affects Versions: 1.19.0
>            Reporter: Sergey Nuyanzin
>            Assignee: Sergey Nuyanzin
>            Priority: Major
>              Labels: pull-request-available
>
> ASM 9.5 (which has support for java 21[1]) came only with ArchUnit 1.1.0 [2]
> With current ArchUnit(1.0.0) in case of jdk21 it fails
> {noformat}
> mvn clean install -DskipTests -Dfast -Pjava21-target
> mvn verify -pl flink-architecture-tests/flink-architecture-tests-production/ 
> -Darchunit.freeze.store.default.allowStoreUpdate=false
> {noformat}
> like
> {noformat}
> Nov 26 16:07:42 16:07:42.024 [ERROR] Tests run: 2, Failures: 0, Errors: 1, 
> Skipped: 0, Time elapsed: 5.742 s <<< FAILURE! - in 
> org.apache.flink.architecture.rules.ITCaseRules
> Nov 26 16:07:42 16:07:42.025 [ERROR] ITCaseRules.ITCASE_USE_MINICLUSTER  Time 
> elapsed: 0.005 s  <<< ERROR!
> Nov 26 16:07:42 
> com.tngtech.archunit.library.freeze.StoreUpdateFailedException: Updating 
> frozen violations is disabled (enable by configuration 
> freeze.store.default.allowStoreUpdate=true)
> Nov 26 16:07:42       at 
> com.tngtech.archunit.library.freeze.ViolationStoreFactory$TextFileBasedViolationStore.save(ViolationStoreFactory.java:125)
> Nov 26 16:07:42       at 
> com.tngtech.archunit.library.freeze.FreezingArchRule$ViolationStoreLineBreakAdapter.save(FreezingArchRule.java:277)
> Nov 26 16:07:42       at 
> com.tngtech.archunit.library.freeze.FreezingArchRule.removeObsoleteViolationsFromStore(FreezingArchRule.java:154)
> Nov 26 16:07:42       at 
> com.tngtech.archunit.library.freeze.FreezingArchRule.removeObsoleteViolationsFromStoreAndReturnNewViolations(FreezingArchRule.java:146)
> Nov 26 16:07:42       at 
> com.tngtech.archunit.library.freeze.FreezingArchRule.evaluate(FreezingArchRule.java:127)
> Nov 26 16:07:42       at 
> com.tngtech.archunit.lang.ArchRule$Assertions.check(ArchRule.java:84)
> Nov 26 16:07:42       at 
> com.tngtech.archunit.library.freeze.FreezingArchRule.check(FreezingArchRule.java:97)
> {noformat}
> [1] https://asm.ow2.io/versions.html#9.5
> [2] https://github.com/TNG/ArchUnit/pull/1098



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to