fsk119 commented on code in PR #23809:
URL: https://github.com/apache/flink/pull/23809#discussion_r1410477547
##########
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliTableauResultView.java:
##########
@@ -38,31 +38,46 @@
import java.util.concurrent.Executors;
import java.util.concurrent.Future;
import java.util.concurrent.atomic.AtomicInteger;
+import java.util.stream.Collectors;
/** Print result in tableau mode. */
public class CliTableauResultView implements AutoCloseable {
+ public static final long DEFAULT_QUERY_BEGIN_TIME = -1L;
+
private final Terminal terminal;
private final ResultDescriptor resultDescriptor;
private final ChangelogResult collectResult;
private final ExecutorService displayResultExecutorService;
- public CliTableauResultView(final Terminal terminal, final
ResultDescriptor resultDescriptor) {
- this(terminal, resultDescriptor, resultDescriptor.createResult());
+ private final long queryBeginTime;
+
+ public CliTableauResultView(
+ final Terminal terminal, final ResultDescriptor resultDescriptor,
long queryBeginTime) {
+ this(terminal, resultDescriptor, resultDescriptor.createResult(),
queryBeginTime);
}
@VisibleForTesting
public CliTableauResultView(
final Terminal terminal,
final ResultDescriptor resultDescriptor,
final ChangelogResult collectResult) {
+ this(terminal, resultDescriptor, collectResult,
DEFAULT_QUERY_BEGIN_TIME);
Review Comment:
I think it's better to simplify the logic. I think we only need to control
with the option only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
