echauchot commented on PR #25: URL: https://github.com/apache/flink-connector-shared-utils/pull/25#issuecomment-1835994166
>> @snuyanzin can you elaborate on the use cases you have in mind for systemPropertyVariable surefire.module.config ? > The use case is testing against jdk17/21 The issue with these jdks is that sometimes it is from one side required to add `add-opens/export` flags for tests like it is done e.g. for flink-core https://github.com/apache/flink/blob/a024f6329593bee1188080ca41808b8ac77b0660/flink-core/pom.xml#L44-L58 > > Similar it is required for connector's code. From another side it's better to keep existing surefire flags. + in case of jdk8 it makes sence to have `-XX:+IgnoreUnrecognizedVMOptions` to make it non failing because of all these `add-[opens|exports]` yes, it was clear already in the comment in the pom. I meant, can you elaborate on why this: `<!-- Expose as property so that test utils that spawn JVMs can pick it up. --> <surefire.module.config>${surefire.module.config}</surefire.module.config>` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
