snuyanzin commented on code in PR #23844:
URL: https://github.com/apache/flink/pull/23844#discussion_r1412350731
##########
flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/HadoopS3AccessHelper.java:
##########
@@ -68,7 +68,7 @@ public HadoopS3AccessHelper(S3AFileSystem s3a, Configuration
conf) {
@Override
public String startMultiPartUpload(String key) throws IOException {
- return s3accessHelper.initiateMultiPartUpload(key);
+ return s3accessHelper.initiateMultiPartUpload(key, null);
Review Comment:
yes, makes sense done
##########
flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/HadoopS3AccessHelper.java:
##########
@@ -84,13 +84,14 @@ public UploadPartResult uploadPart(
null,
inputFile,
0L);
- return s3accessHelper.uploadPart(uploadRequest);
+ return s3accessHelper.uploadPart(uploadRequest, null);
}
@Override
public PutObjectResult putObject(String key, File inputFile) throws
IOException {
- final PutObjectRequest putRequest =
s3accessHelper.createPutObjectRequest(key, inputFile);
- return s3accessHelper.putObject(putRequest);
+ final PutObjectRequest putRequest =
+ s3accessHelper.createPutObjectRequest(key, inputFile, null);
+ return s3accessHelper.putObject(putRequest, null, null);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
