JingGe commented on code in PR #23858:
URL: https://github.com/apache/flink/pull/23858#discussion_r1413009264
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java:
##########
@@ -142,7 +142,7 @@ public class JoinTestPrograms {
.setupTableSource(SOURCE_T1)
.setupTableSource(SOURCE_T2)
.setupTableSink(
- SinkTestStep.newBuilder("MySink")
+
SinkTestStep.newBuilder("NON_WINDOW_INNER_JOIN_WITH_NULL_Sink")
Review Comment:
It is a great idea to use data warehouse like naming convention to improve
the readability. It would be even better to follow the naming convention that
table names commonly use lower case letters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
