zoudan commented on code in PR #23849:
URL: https://github.com/apache/flink/pull/23849#discussion_r1415242114
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ResultProvider.java:
##########
@@ -59,4 +59,7 @@ public interface ResultProvider {
* {@link CloseableIterator#next()} method returns a row.
*/
boolean isFirstRowReady();
+
+ /** Reset this ResultProvider to the origin state when we create it. */
+ default void reset() {}
Review Comment:
You are right, but the problem is that Flink creates the `ResultProvider`
while translating `ModifyOperation` into `Transformation`(in
DynamicSinkUtils#convertCollectToRel, and we will not call this when hit a plan
cache). I find it hard to recreate a new one here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
