dawidwys commented on code in PR #23869:
URL: https://github.com/apache/flink/pull/23869#discussion_r1415790788
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java:
##########
@@ -107,7 +107,7 @@ public class JoinTestPrograms {
static {
NON_WINDOW_INNER_JOIN =
- TableTestProgram.of("non-window-inner-join", "test non-window
inner join")
+ TableTestProgram.of("join-non-window-inner-join", "test
non-window inner join")
Review Comment:
Hope you won't find it nitpicking, but can we leave just a single occurence
of `join`? I think `join-non-window-inner` still makes sense, but I am not a
native speaker. If you find the duplication better leave it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
