1996fanrui commented on code in PR #23247:
URL: https://github.com/apache/flink/pull/23247#discussion_r1417489771
##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/RestartBackoffTimeStrategyFactoryLoader.java:
##########
@@ -116,7 +116,9 @@ private static Optional<RestartBackoffTimeStrategy.Factory>
getJobRestartStrateg
exponentialDelayConfig.getMaxBackoff().toMilliseconds(),
exponentialDelayConfig.getBackoffMultiplier(),
exponentialDelayConfig.getResetBackoffThreshold().toMilliseconds(),
- exponentialDelayConfig.getJitterFactor()));
+ exponentialDelayConfig.getJitterFactor(),
+
RestartStrategyOptions.RESTART_STRATEGY_EXPONENTIAL_DELAY_ATTEMPTS
Review Comment:
I didn't do it because `ExponentialDelayRestartStrategyConfiguration` is
deprecated since 1.19. The `RestartStrategies` has been deprecated, and
`ExponentialDelayRestartStrategyConfiguration` is the inner class of it.
So the new option won't be supportted in the deprecated api.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
