pnowojski commented on code in PR #23845: URL: https://github.com/apache/flink/pull/23845#discussion_r1418691746
########## docs/content/docs/deployment/config.md: ########## @@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded performance and should be s ---- ---- +# Traces Review Comment: Huh, good catch. I was curious a couple of times why the TOC seem broken, but never investigated it. I think this is a good fix, but let's ask @zentol maybe. On the other hand, arguably we shouldn't have more than a single Header lvl 1. So maybe the bug is in all of the pages that have more than one lvl 1 header? But that would be fragile and prone mistakes happening again I guess. So all in all I'm +1 for setting the `startLeve = 1` ########## docs/content/docs/deployment/config.md: ########## @@ -289,6 +289,15 @@ Enabling RocksDB's native metrics may cause degraded performance and should be s ---- ---- +# Traces Review Comment: Huh, good catch. I was curious a couple of times why the TOC seem broken, but never investigated it. I think this is a good fix, but let's ask @zentol maybe. On the other hand, arguably we shouldn't have more than a single Header lvl 1. So maybe the bug is in all of the pages that have more than one lvl 1 header? But that would be fragile and prone mistakes happening again I guess. So all in all I'm +1 for setting the `startLevel = 1` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org