mxm commented on code in PR #724:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/724#discussion_r1419022782
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java:
##########
@@ -306,6 +319,40 @@ protected void resubmitJob(FlinkResourceContext<CR> ctx,
boolean requireHaMetada
restoreJob(ctx, specToRecover, ctx.getObserveConfig(),
requireHaMetadata);
}
+ private void redeployWithSavepoint(
+ FlinkResourceContext<CR> ctx,
+ Configuration deployConfig,
+ CR resource,
+ STATUS status,
+ SPEC currentDeploySpec,
+ JobState desiredJobState)
+ throws Exception {
+ LOG.info("Redeploying from savepoint");
+ cancelJob(ctx, UpgradeMode.STATELESS);
+ var savepointOpt =
+
Optional.ofNullable(currentDeploySpec.getJob().getInitialSavepointPath());
+ currentDeploySpec
+ .getJob()
+ .setUpgradeMode(
+ savepointOpt.isPresent() ? UpgradeMode.SAVEPOINT :
UpgradeMode.STATELESS);
Review Comment:
Recommending to use this feature with an empty savepointpath to clear the
state, without having to change the upgradeMode to stateless, seems beyond the
scope of this change. I don't think we should allow this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
