LadyForest commented on code in PR #23678:
URL: https://github.com/apache/flink/pull/23678#discussion_r1421891193
##########
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/datagen/table/DataGenConnectorOptions.java:
##########
@@ -118,10 +118,10 @@ public class DataGenConnectorOptions {
.withDescription("The proportion of null values.");
/** Placeholder {@link ConfigOption}. Not used for retrieving values. */
- public static final ConfigOption<Float> FIELD_VAR_LEN =
+ public static final ConfigOption<Boolean> FIELD_VAR_LEN =
ConfigOptions.key(String.format("%s.#.%s", FIELDS, VAR_LEN))
- .floatType()
- .defaultValue(0f)
+ .booleanType()
+ .defaultValue(false)
Review Comment:
I'm a little bit confused. Why change this config type?
##########
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/connector/datagen/table/RandomGeneratorVisitor.java:
##########
@@ -489,6 +465,16 @@ protected DataGeneratorContainer defaultMethod(LogicalType
logicalType) {
throw new ValidationException("Unsupported type: " + logicalType);
}
+ private ConfigOption<Integer> getLengthOption(Supplier<Integer>
defaultLengthSupplier) {
Review Comment:
`ArrayType`, `MultisetType,` and `MapType` can also use this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
