[ 
https://issues.apache.org/jira/browse/FLINK-33634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795170#comment-17795170
 ] 

Gyula Fora commented on FLINK-33634:
------------------------------------

I don't think the idea was to migrate from status to condition. I think the 
status is completely fine as it is currently (of course there are always some 
improvements to be made later for new versions). Most of the status is not 
userfacing anyways.

I think we can just take some part of it as you mentions like the 
job/jobmanager state and expose that.

Things like save points / reconciliations succeeded I definitely would not add.

> Add Conditions to Flink CRD's Status field
> ------------------------------------------
>
>                 Key: FLINK-33634
>                 URL: https://issues.apache.org/jira/browse/FLINK-33634
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kubernetes Operator
>    Affects Versions: kubernetes-operator-1.7.0
>            Reporter: Tony Garrard
>            Priority: Major
>
> From 
> [https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties]
>  it is considered best practice to provide Conditions in the Status of CRD's. 
> Some tooling even expects there to be a Conditions field in the status of a 
> CR. This issue to to propose adding a Conditions field to the CR status
> e.g.
> status:
>     conditions:
>      - lastTransitionTime: '2023-11-23T12:38:51Z'
>        status: 'True'
>        type: Ready



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to