ryanvanhuuksloot commented on code in PR #727:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/727#discussion_r1423102408
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/IngressUtils.java:
##########
@@ -93,24 +96,45 @@ private static HasMetadata getIngress(
if (ingressInNetworkingV1(client)) {
return new IngressBuilder()
.withNewMetadata()
+ .withLabels(spec.getIngress().getLabels())
.withAnnotations(spec.getIngress().getAnnotations())
.withName(objectMeta.getName())
.withNamespace(objectMeta.getNamespace())
.endMetadata()
.withNewSpec()
.withIngressClassName(spec.getIngress().getClassName())
+ .withTls(spec.getIngress().getTls())
.withRules(getIngressRule(objectMeta, spec,
effectiveConfig))
.endSpec()
.build();
} else {
+ List<IngressTLS> ingressTLS =
Review Comment:
Pulled it outside of the return because otherwise it is even more impossible
to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
