dawidwys commented on code in PR #23884:
URL: https://github.com/apache/flink/pull/23884#discussion_r1423697501
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/SourceQueryOperation.java:
##########
@@ -76,6 +78,25 @@ public String asSummaryString() {
"CatalogTable", args, getChildren(),
Operation::asSummaryString);
}
+ @Override
+ public String asSerializableString() {
+ final StringBuilder stringBuilder = new StringBuilder();
+ stringBuilder.append(
+ String.format(
+ "SELECT %s FROM %s",
+ getResolvedSchema().getColumnNames().stream()
+ .map(EncodingUtils::escapeIdentifier)
+ .collect(Collectors.joining(", ")),
+
getContextResolvedTable().getIdentifier().asSerializableString()));
+
+ if (dynamicOptions != null) {
+ stringBuilder.append(
+ String.format("OPTIONS (%s)",
OperationUtils.formatProperties(dynamicOptions)));
Review Comment:
Yes, I did. However, after trying to fix it, I noticed there is actually no
way to pass dynamic options from Table Api. I'll throw an exception for now if
there are options set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
