gyfora commented on PR #726: URL: https://github.com/apache/flink-kubernetes-operator/pull/726#issuecomment-1852176197
I addressed all comments I believe @1996fanrui @mxm . Please note that I also added a second commit with the metrics improvements separately, not only does this fix the issue highlighted by @1996fanrui but it also remove some previously incorrectly reported per vertex metrics (those that we did not actually evaluate so were also nan) + adds LAG as an evaluated metric for metric completeness (I'm going to add a test for this before merging) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
