zhengzhili333 commented on code in PR #23880:
URL: https://github.com/apache/flink/pull/23880#discussion_r1426063623
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/JobGraphWriter.java:
##########
@@ -37,6 +38,18 @@ public interface JobGraphWriter extends
LocallyCleanableResource, GloballyCleana
*/
void putJobGraph(JobGraph jobGraph) throws Exception;
+ /**
+ * Adds the {@link JobGraph} instance and have write operations performed
asynchronously in
+ * ioExecutor of Dispatcher
+ *
+ * @param jobGraph
+ * @param ioExecutor
+ * @return
+ * @throws Exception
+ */
+ CompletableFuture<Void> putJobGraphAsync(JobGraph jobGraph,
Optional<Executor> ioExecutor)
Review Comment:
Thank you for your reminder.Changing the interface violates the open/close
principle, but it is not necessary to maintain two interfaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
