masteryhx commented on PR #21635:
URL: https://github.com/apache/flink/pull/21635#issuecomment-1855044542

   > Hi @masteryhx , thanks for the contribution and update!
   > 
   > I have reviewed this PR and left some comments. Please take a look in your 
free time, thanks~
   > 
   > Also, `The Schema Compatibility` related code is Flinkā€™s infrastructure 
and is used by many components. I didn't change and read related code before 
this PR, so I'm not professional in this area. I have reviewed, but it would be 
great to have more committers who are familiar with this area to help review. 
It will be helpful for the bug-free.
   
   Thanks a lot for the detailed review.
   We may have some key problems remaing in the comment to discuss.
   I'll update the pr after we are on the same way about these problems.
   Also ping @Zakelly @fredia here to help to review and discuss together, 
Thanks a lot for your time!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to