Zakelly opened a new pull request, #23928:
URL: https://github.com/apache/flink/pull/23928

   ## What is the purpose of the change
   
   Currently, the TtlValueState#update will wrap the user value with timestamp 
and proxy request to the original value state. It does not check the null 
value, which violates the description of the base interface. This PR fixes this 
by enforcing null value check before wrapping.
   
   
   ## Brief change log
   
     - check the null value before wrapping in TtlValueState#update
    
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
     - Added test case `testValueSetNull` in `TtlStateTestBase.java`, and make 
the value of `TtlValueStateTestContext` be `Long` to throw exception when 
serializing null.  
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency):  **no**
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **yes**
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **not applicable**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to