gyfora commented on code in PR #726:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/726#discussion_r1426670350
##########
flink-autoscaler/src/test/java/org/apache/flink/autoscaler/MetricsCollectionAndEvaluationTest.java:
##########
@@ -188,6 +187,13 @@ public void testEndToEnd() throws Exception {
assertNotNull(metricsCollector.getHistories().get(context.getJobKey()));
+ // Make sure all reported vertex metrics are evaluated, we expect
complete metrics when a
+ // vertex is actually scaled
+ // Also for sources we have LAG metrics that is not available for
other vertices
+ assertEquals(
+ ScalingMetric.REPORTED_VERTEX_METRICS,
+ evaluation.getVertexMetrics().get(source1).keySet());
Review Comment:
@1996fanrui this is the added test for metric reporting / evaluation
completeness
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
