RocMarshal commented on code in PR #23932:
URL: https://github.com/apache/flink/pull/23932#discussion_r1427882696
##########
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolBridgeResourceDeclarationTest.java:
##########
@@ -141,40 +137,38 @@ public void
testRequirementsDecreasedOnAllocationTimeout() throws Exception {
.get();
// waiting for the timeout
- assertThat(
- allocationFuture,
-
FlinkMatchers.futureWillCompleteExceptionally(Duration.ofMinutes(1)));
-
+
assertThatFuture(allocationFuture).failsWithin(Duration.ofMinutes(1));
+ Thread.sleep(5L);
Review Comment:
Nice catch!
sorry for it. Maybe it's a dirty line from the cp.
I'll remove it and check it on the other corresponding PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
