mxm commented on code in PR #728:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1429838068
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricCollector.java:
##########
@@ -143,7 +145,11 @@ public CollectedMetricHistory updateMetrics(
if (now.isBefore(windowFullTime)) {
LOG.info("Metric window not full until {}", windowFullTime);
} else {
- collectedMetrics.setFullyCollected(true);
+ if (isExcluded) {
+ LOG.info("autoscaling now in excluded period");
Review Comment:
```suggestion
LOG.info("Autoscaling on halt based on exclusion rule {}",
conf.get(AutoScalerOptions. EXCLUDED_PERIODS));
```
I think this could be helpful for debugging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
