twalthr commented on code in PR #23948:
URL: https://github.com/apache/flink/pull/23948#discussion_r1430361998


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/PlannerQueryOperation.java:
##########
@@ -72,6 +75,13 @@ public String asSummaryString() {
                 "PlannerNode", Collections.emptyMap(), getChildren(), 
Operation::asSummaryString);
     }
 
+    @Override
+    public String asSerializableString() {
+        final RelToSqlConverter relToSqlConverter = new 
RelToSqlConverter(AnsiSqlDialect.DEFAULT);

Review Comment:
   We should not expose Calcite exceptions in this case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to