lsyldliu commented on code in PR #18375:
URL: https://github.com/apache/flink/pull/18375#discussion_r1431348856
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/aggfunctions/MaxWithRetractAggFunctionTest.java:
##########
@@ -317,6 +318,31 @@ protected List<StringData> getExpectedResults() {
}
}
+ /** Test for {@link CharType}. */
+ public static final class CharMaxWithRetractAggFunctionTest
+ extends MaxWithRetractAggFunctionTestBase<Character> {
Review Comment:
Why do we need to add this test? CharType and VarCharType both are based on
StringData, this test is useless?
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/aggfunctions/MinWithRetractAggFunctionTest.java:
##########
@@ -317,6 +318,31 @@ protected List<StringData> getExpectedResults() {
}
}
+ /** Test for {@link CharType}. */
+ public static final class CharMinWithRetractAggFunctionTest
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
