Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2805#discussion_r87967007
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ---
    @@ -586,7 +588,18 @@ private boolean performCheckpoint(CheckpointMetaData 
checkpointMetaData) throws
                                // yet be created
                                final CancelCheckpointMarker message = new 
CancelCheckpointMarker(checkpointMetaData.getCheckpointId());
                                for (ResultPartitionWriter output : 
getEnvironment().getAllWriters()) {
    -                                   output.writeEventToAllChannels(message);
    +                                   final Buffer eventBuffer = 
EventSerializer.toBuffer(message);
    --- End diff --
    
    in any case the entire try/finally block could be moved into the 
ResultPartitionWriter, correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to