[ 
https://issues.apache.org/jira/browse/FLINK-33528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799315#comment-17799315
 ] 

Sergey Nuyanzin commented on FLINK-33528:
-----------------------------------------

[~pvary], [~dianfu] could you please clarify: once externalization of python 
code for some connector happened could we safely remove the related connector's 
python code from flink main repo?

> Externalize Python connector code
> ---------------------------------
>
>                 Key: FLINK-33528
>                 URL: https://issues.apache.org/jira/browse/FLINK-33528
>             Project: Flink
>          Issue Type: Technical Debt
>          Components: API / Python, Connectors / Common
>    Affects Versions: 1.18.0
>            Reporter: Márton Balassi
>            Assignee: Peter Vary
>            Priority: Major
>             Fix For: 1.19.0
>
>
> During the connector externalization effort end to end tests for the python 
> connectors were left in the main repository under:
> [https://github.com/apache/flink/tree/master/flink-python/pyflink/datastream/connectors]
> These include both python connector implementation and tests. Currently they 
> depend on a previously released version of the underlying connectors, 
> otherwise they would introduce a circular dependency given that they are in 
> the flink repo at the moment.
> This setup prevents us from propagating any breaking change to PublicEvolving 
> and Internal APIs used by the connectors as they lead to breaking the python 
> e2e tests. We run into this while implementing FLINK-25857.
> Note that we made the decision to turn off the Python test when merging 
> FLINK-25857, so now we are forced to fix this until 1.19 such that we can 
> reenable the test runs - now in the externalized connector repos.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to