libenchao commented on code in PR #23984:
URL: https://github.com/apache/flink/pull/23984#discussion_r1434845148
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/TableConfigOptions.java:
##########
@@ -233,6 +233,16 @@ private TableConfigOptions() {}
.withDescription(
"Specifies a threshold where class members of
generated code will be grouped into arrays by types.");
+ @Documentation.TableOption(execMode =
Documentation.ExecMode.BATCH_STREAMING)
+ public static final ConfigOption<Boolean> INDEPENDENT_NAME_COUNTER_ENABLED
=
Review Comment:
Why do we need this config, I think it's ok to change the behavior by
default, it's no meaning to expose it to users.
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/HashCodeGenerator.scala:
##########
@@ -80,23 +80,25 @@ object HashCodeGenerator {
}
""".stripMargin
+ System.out.println(code)
Review Comment:
Remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
