flashJd commented on code in PR #728:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1436333329
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java:
##########
@@ -72,6 +72,21 @@ private static ConfigOptions.OptionBuilder
autoScalerConfig(String key) {
.withDescription(
"Stabilization period in which no new scaling will
be executed");
+ public static final ConfigOption<List<String>> EXCLUDED_PERIODS =
+ autoScalerConfig("excluded.periods")
+ .stringType()
+ .asList()
+ .defaultValues()
Review Comment:
@1996fanrui change the defaultValue to `noDefaultValue` causes NPE， we have
to add many annoying
notNull judgments, as config `vertex.exclude.ids` also set to
defaultValues(), I referred to it, what do you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
