MartijnVisser commented on code in PR #67:
URL:
https://github.com/apache/flink-connector-jdbc/pull/67#discussion_r1437683689
##########
flink-connector-jdbc/pom.xml:
##########
@@ -38,10 +38,12 @@ under the License.
<scala.binary.version>2.12</scala.binary.version>
<scala-library.version>2.12.7</scala-library.version>
<assertj.version>3.23.1</assertj.version>
+ <jackson.version>2.15.2</jackson.version>
<postgres.version>42.5.1</postgres.version>
<oracle.version>21.8.0.0</oracle.version>
<trino.version>418</trino.version>
<byte-buddy.version>1.12.10</byte-buddy.version>
+ <elasticsearch.version>8.11.1</elasticsearch.version>
Review Comment:
> What should be done to ensure if adding this dependency (even as
"provided") is allowed?
I think we should add an enforcer rule to make sure that it's never bundled.
Next to that, I think we should make a similar statement in the docs as we've
done for RabbitMQ (see
https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/datastream/rabbitmq/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
