RocMarshal commented on code in PR #23867:
URL: https://github.com/apache/flink/pull/23867#discussion_r1438455564


##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/ExponentialDelayRestartBackoffTimeStrategy.java:
##########


Review Comment:
   how about 
   
   ```
           checkArgument(initialBackoffMS >= 1, "Initial backoff must be at 
least 1.");
           checkArgument(maxBackoffMS >= 1, "Maximum backoff must be at least 
1.");
           checkArgument(
                   initialBackoffMS <= maxBackoffMS,
                   "Initial backoff cannot be higher than maximum backoff.");
   ```
   
   ->
   
   
   
   ```
           checkArgument(maxBackoffMS >= 1, "Maximum backoff must be at least 
1.");
           checkArgument(
                   initialBackoffMS <= maxBackoffMS && initialBackoffMS >= 1,
                   "Initial backoff must be at least 1 and mustn't be higher 
than maximum backoff");
           
   ```
      
   Because the new message prompts could be more complete for users.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to