[ 
https://issues.apache.org/jira/browse/FLINK-33897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803185#comment-17803185
 ] 

Piotr Nowojski commented on FLINK-33897:
----------------------------------------

I have mixed feelings. Shouldn't the solution be to just use/enable unaligned 
checkpoints? If one sets the alignment timeout to some reasonable value, I 
don't see a reason for someone to use aligned checkpoints anymore. Maybe 
instead let's consider deprecating aligned checkpoints without timeout?

Is there some real world motivation behind this feature?

I would be -1 for this feature, if it requires complicating/making changes to 
the actual barrier handling (apart of replacing 
{{SingleCheckpointBarrierHandler#aligned}} with 
{{SingleCheckpointBarrierHandler#alternating}} call). This code is complicated 
and in the past we had a lot of deadlocks, data corruptions and other critical 
bugs around those areas, so keeping it as simple as possible and minimising 
amount of supported features is quite important. 

> Allow triggering unaligned checkpoint via CLI
> ---------------------------------------------
>
>                 Key: FLINK-33897
>                 URL: https://issues.apache.org/jira/browse/FLINK-33897
>             Project: Flink
>          Issue Type: Improvement
>          Components: Command Line Client, Runtime / Checkpointing
>            Reporter: Zakelly Lan
>            Assignee: Zakelly Lan
>            Priority: Major
>
> After FLINK-6755, user could trigger checkpoint through CLI. However I 
> noticed there would be value supporting trigger it in unaligned way, since 
> the job may encounter a high back-pressure and an aligned checkpoint would 
> fail.
>  
> I suggest we provide an option '-unaligned' in CLI to support that.
>  
> Similar option would also be useful for REST api



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to