StefanRRichter commented on code in PR #23908: URL: https://github.com/apache/flink/pull/23908#discussion_r1442679306
########## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java: ########## @@ -730,57 +739,87 @@ void restoreInternal() throws Exception { getEnvironment().getMetricGroup().getIOMetricGroup().markTaskInitializationStarted(); LOG.debug("Initializing {}.", getName()); - operatorChain = - getEnvironment().getTaskStateManager().isTaskDeployedAsFinished() - ? new FinishedOperatorChain<>(this, recordWriter) - : new RegularOperatorChain<>(this, recordWriter); - mainOperator = operatorChain.getMainOperator(); + SubTaskInitializationMetricsBuilder initializationMetrics = + new SubTaskInitializationMetricsBuilder( + SystemClock.getInstance().absoluteTimeMillis()); + try { + operatorChain = + getEnvironment().getTaskStateManager().isTaskDeployedAsFinished() + ? new FinishedOperatorChain<>(this, recordWriter) + : new RegularOperatorChain<>(this, recordWriter); + mainOperator = operatorChain.getMainOperator(); - getEnvironment() - .getTaskStateManager() - .getRestoreCheckpointId() - .ifPresent(restoreId -> latestReportCheckpointId = restoreId); + getEnvironment() Review Comment: Argh, yes sorry reviewing in GH sometimes stinks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org