bvarghese1 commented on PR #24020: URL: https://github.com/apache/flink/pull/24020#issuecomment-1883622718
> From very quick skimming... I looked at `SourceAbilitySpec`, and it looks like this test ought to help cover the `JsonSubTypes` there. > > I think I see the following readily: > > ``` > ProjectPushDownSpec > FilterPushDownSpec > LimitPushDownSpec > PartitionPushDownSpec > ReadingMetadataSpec > WatermarkPushDownSpec > ``` > > Is there coverage for the other two? > > ``` > SourceWatermarkSpec > AggregatePushDownSpec > ``` Added coverage for `SourceWatermarkSpec`. `AggregatePushDownSpec` is only supported in BATCH mode - https://github.com/apache/flink/blob/master/flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/OptimizerConfigOptions.java#L106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
