StefanRRichter commented on code in PR #24031: URL: https://github.com/apache/flink/pull/24031#discussion_r1447413810
########## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/EmbeddedRocksDBStateBackend.java: ########## @@ -305,6 +311,11 @@ private EmbeddedRocksDBStateBackend( overlapFractionThreshold >= 0 && this.overlapFractionThreshold <= 1, "Overlap fraction threshold of restoring should be between 0 and 1"); + useIngestDbRestoreMode = + original.useIngestDbRestoreMode == UNDEFINED_USE_INGEST_DB_RESTORE_MODE + ? config.get(USE_INGEST_DB_RESTORE_MODE) + : original.useIngestDbRestoreMode; Review Comment: Yep, I think we better use `Boolean`and `null` for undefined. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org