MOBIN-F commented on code in PR #36:
URL:
https://github.com/apache/flink-connector-hbase/pull/36#discussion_r1452863933
##########
flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/sink/RowDataToMutationConverter.java:
##########
@@ -43,23 +43,26 @@ public class RowDataToMutationConverter implements
HBaseMutationConverter<RowDat
private final TimestampMetadata timestampMetadata;
private final TimeToLiveMetadata timeToLiveMetadata;
private transient HBaseSerde serde;
+ private final boolean dynamicTable;
Review Comment:
ok
##########
flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/table/HBaseConnectorOptions.java:
##########
@@ -60,6 +60,12 @@ public class HBaseConnectorOptions {
"Representation for null values for string fields.
HBase source and "
+ "sink encodes/decodes empty bytes as
null values for all types except string type.");
+ public static final ConfigOption<Boolean> DYNAMIC_TABLE =
+ ConfigOptions.key("dynamic.table")
Review Comment:
yep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
