1996fanrui opened a new pull request, #757:
URL: https://github.com/apache/flink-kubernetes-operator/pull/757

   ## What is the purpose of the change
   
   Currently, the scaling report format is  `Vertex ID %s | Parallelism %d -> 
%d | Processing capacity %.2f -> %.2f | Target data rate %.2f`.
   
   It has 2 disadvantages:
   
   1. When one job has multiple vertices, the report of all vertices are mixed 
together without any separator, here is an example:
       - `Scaling execution enabled, begin scaling vertices: Vertex ID 
ea632d67b7d595e5b851708ae9ad79d6 | Parallelism 2 -> 1 | Processing capacity 
800466.67 -> 320186.67 | Target data rate 715.10 Vertex ID 
bc764cd8ddf7a0cff126f51c16239658 | Parallelism 2 -> 1 | Processing capacity 
79252.08 -> 31700.83 | Target data rate 895.93 Vertex ID 
0a448493b4782967b150582570326227 | Parallelism 8 -> 16 | Processing capacity 
716.05 -> 1141.00 | Target data rate 715.54`
       - We can see the Vertex ID is the beginning of each vertex report, it 
doesn't have any separator with the last vertex.
   2. This format is non-standard, it's hard to deserialize.
       - When job enables the autoscaler and disable the scaling.
       - Flink platform maintainer wants to show the scaling report in WebUI, 
it's helpful to using the report result for flink users.
       - So easy to deserialize is useful for these flink platform.
   
   ## Brief change log
   
   Serializing the scaling report with json format, it's easy to read and 
deserialize.
   
   Here is the scaling report message after this PR:  ``
   
   ## Verifying this change
   
     - Added `AutoScalerEventHandlerTest` to test the ScalingReport format.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency):  no
     - The public API, i.e., is any changes to the `CustomResourceDescriptors`: 
no
     - Core observer or reconciler logic that is regularly executed: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to