1996fanrui commented on code in PR #24042:
URL: https://github.com/apache/flink/pull/24042#discussion_r1453038598
##########
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java:
##########
@@ -216,6 +229,24 @@ public YarnClusterDescriptor(
this.nodeLabel =
flinkConfiguration.getString(YarnConfigOptions.NODE_LABEL);
}
+ /** Adapt flink env setting. */
+ private static <T> void adaptEnvSetting(
+ Configuration config,
+ ConfigOption<T> configOption,
+ String envKey,
+ Function<T, Boolean> validator) {
Review Comment:
As I understand, this `validator` wanna check whether the value of
`configOption` in config is legal.
- If it's legal, we can add the env
- If it's illegal, we will ignore.
Is my understanding right?
If right, I don't think we should do this check here. I mean we should cover
Flink on Kubernetes if we wanna check whether it's legal. So check them in the
yarn side doesn't make sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
